Re: [PATCH 2/6] perf, tools: Support handling complete branch stacksas histograms v3

From: Jiri Olsa
Date: Wed Jan 15 2014 - 10:45:52 EST


On Wed, Jan 15, 2014 at 04:27:29PM +0100, Andi Kleen wrote:
> > this option is not added in this patch, I tried:
> > $ perf report --call-graph=fractal,0.5,callee,function,branch
>
> Of course not, it's in the next patch.
>
> But I was not putting the cumbersome long command line into this
> example.
>
> If you really feel strongly about it I guess the two patches could be merged,
> but seems cleaner separated.
>
> >
> > but as I already said in reply for patch 3, it's not working
> > please update the doc in Documentation/perf-report.txt with an example
>
> What kind of example? Full output for a command?
>
> I don't think any other option has that in the man page. It would be
> unique.
>
> Having a illustrated `perf tutorial' with examples would probably be a
> good idea, but I'm not sure the man page is the right place for that.
>

yea.. example would be too much ;-) but at least all available options
are mentioned in '--call-graph::' section in Documentation/perf-report.txt
and 'branch' is missing

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/