Re: [PATCH 3/5] perf report: Add --percentage option

[Arnaldo Carvalho de Melo]

Em Wed, Jan 15, 2014 at 11:18:23AM +0900, Namhyung Kim escreveu:
> On Tue, 14 Jan 2014 18:25:55 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 14, 2014 at 01:07:00PM -0800, Andi Kleen escreveu:
> >> Namhyung Kim <namhyung@xxxxxxxxxx> writes:
> >> >  
> >> > +--percentage::
> >> > +	Determine how to display the overhead percentage of filtered
> >> > entries.
> >> 
> >> This should describe also what a "filtered entry" exactly is. It's not clear
> >> even to me.
> >
> > Yeah, the text should give some context, mentioning the "Zoom"
> > operations that can be done in the TUI (DSO, thread, etc) that allows
> > applying what he is calling "filters".`
> 
> Ah, okay.
> 
> How about this:

Ack, much clearer, minor things below:
 
> 
> -c::
> --comms=::
> 	Only consider symbols in these comms. CSV that understands
> 	file://filename entries.  This option will affect the percentage of
> 	overhead column.  See --percentage for more info.
        the overhead column. ...
> -d::
> --dsos=::
> 	Only consider symbols in these dsos. CSV that understands
> 	file://filename entries.  This option will affect the percentage of
> 	overhead column.  See --percentage for more info.

ditto

> -S::
> --symbols=::
> 	Only consider these symbols. CSV that understands
> 	file://filename entries.  This option will affect the percentage of
> 	overhead column.  See --percentage for more info.

ditto

> 
> --percentage::
> 	Determine how to display the overhead percentage of filtered entries.
> 	Filters can be applied by --comms, --dsos and/or --symbols options and
> 	Zoom operations on the TUI (thread, dso, etc).
> 
> 	"relative" means it's relative to filtered entries only so that the
> 	sum of shown entries will be always 100%.  "absolute" means it retains
> 	original value before and after the filter applied.

Another missing 'the': "... retains the original value ..." plus a
missing 'is' just before 'applied'.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/