Re: Problems with simple-card

From: Mark Brown
Date: Wed Jan 15 2014 - 13:56:46 EST


On Wed, Jan 15, 2014 at 07:18:31PM +0100, Jean-Francois Moine wrote:

> The main problem is about sysclk: when there is no clock in the DT,
> you get the clock of the CPU or CODEC DAI. In my system, two clocks
> are declared in the controller CPU DAI, but there is no .set_sysclk
> pointer. So, snd_soc_dai_set_sysclk() returns -EINVAL and the card is
> not created.

set_sysclk() should be returning -ENOTSUPP in this case as with
set_fmt() and the generic code then ignoring that error.

> As I don't know why you need these fmt and sysclk, may you have a
> look at these problems?

The overwhelming majority of combinations of devices need a format
specifying (usually one will be imposed by the system design even if
both devices could be master).

Attachment: signature.asc
Description: Digital signature