Re: [RFC][PATCH 5/9] mm: rearrange struct page

From: Kirill A. Shutemov
Date: Wed Jan 15 2014 - 19:20:13 EST


On Tue, Jan 14, 2014 at 10:00:55AM -0800, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>
> To make the layout of 'struct page' look nicer, I broke
> up a few of the unions. But, this has a cost: things that
> were guaranteed to line up before might not any more. To make up
> for that, some BUILD_BUG_ON()s are added to manually check for
> the alignment dependencies.
>
> This makes it *MUCH* more clear how the first few fields of
> 'struct page' get used by the slab allocators.
>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>

Looks much cleaner!

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/