Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into asingle argument

From: Oleg Nesterov
Date: Tue Jan 21 2014 - 12:27:56 EST


On 01/21, Peter Zijlstra wrote:
>
> I tried the below but filed to see my vmlinux shrink, maybe I'm just not
> building the right kernel, or otherwise GCC is stupid.

...

> +struct lockdep_acquire_flags {
> + unsigned long subclass : 3;
> + unsigned long trylock : 1;
> + unsigned long read : 2;
> + unsigned long check : 1;
> +};

Yes, I tried this too. I do see the difference, but the result is worse:

- 5262832
+ 5256987

looks like, gcc is not smart enough...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/