Re: [PATCH 3/10] framebuffer: fix cfb_copyarea

From: Mikulas Patocka
Date: Thu Jan 23 2014 - 15:44:45 EST




On Thu, 23 Jan 2014, Geert Uytterhoeven wrote:

> On Thu, Jan 23, 2014 at 7:18 PM, Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote:
> > The cfb_copyarea code was very buggy and it looks like it was written
> > and never tried with non-8-pixel font.
>
> My memory may suffer from bitrot, but I think I tested it with the Sun
> 12x22 font. That was on big endian (PPC), though.

The bug happens when the horizontal font size in bytes is not divisible by
(sizeof(long) / 2).

Mikulas

> BTW, good to see you still have a working TGA. My PPC and Alpha gear
> died a decade ago.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/