Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

From: Kuninori Morimoto
Date: Fri Jan 24 2014 - 03:58:53 EST



Hi Geert

> > This driver is called from shdma-base.c.
> > And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style.
> >
> > 1) this "slave_id" came from shdma_ops::set_slave
> > and, it is using "int"
> > 2) above drivers have same xxx_find_slave(),
> > they are using "int".
> > (this driver is based on that)
> >
> > What should I do ?
>
> OK, then you should keep using int, and change the test to:
>
> if (slave_id < 0 || slave_id >= AUDMAPP_SLAVE_NUMBER)

I see
Thank you

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/