Re: [PATCH -next] isp1704_charger: remove useless check inisp1704_charger_probe()

[Dmitry Eremin-Solenikov]

On Tue, Jan 07, 2014 at 09:12:29PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
> return a NULL result, so remove the useless !isp->phy check.

Thank you, applying.

> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/power/isp1704_charger.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 80edb7d..0b4cf9d 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
>  		ret = PTR_ERR(isp->phy);
>  		goto fail0;
>  	}
> -	if (!isp->phy)
> -		goto fail0;
>  
>  	isp->dev = &pdev->dev;
>  	platform_set_drvdata(pdev, isp);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/