Re: [PATCH 0/5] ia64 ski emulator patches

From: Mikael Pettersson
Date: Sat Jan 25 2014 - 16:08:28 EST


Mikulas Patocka writes:
>
>
> On Sat, 25 Jan 2014, Mikael Pettersson wrote:
>
> > My ski patches are in <http://user.it.uu.se/~mikpe/linux/patches/ia64/ski-1.3.2/>
> > for now. I'll post the kernel patches to linux-ia64 @ vger in a few minutes.
> >
> > /Mikael
>
> Thanks for the patches.
>
> Isn't this subject to races? - could it lock up if the signal happens just
> before the pause syscall?
>
> + case SSC_HALT_LIGHT:
> + /* Sleep until SIGIO or SIGALRM is received; this relies on
> + keyboard/ethernet input being detected via SIGIO, and the
> + ITC now being emulated via setitimer() and SIGALRM. */
> + pause ();
> + break;
> +

Thanks for the review. You're right, the pause mustn't happen if
itc_itimer_fired == 1. Let me ponder this for a while...

/Mikael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/