Re: [PATCH] vfs: respect FMODE_UNSIGNED_OFFSET inp(read|write)[v]*().

From: Al Viro
Date: Wed Jan 29 2014 - 10:18:22 EST


On Wed, Jan 29, 2014 at 11:57:20AM +0000, Nick Alcock wrote:
> ssize_t ret = -EBADF;
>
> - if (pos < 0)
> + f = fdget(fd);
> + if ((pos < 0) && (!f.file || !unsigned_offsets(f.file))) {
> + fdput(f);
> return -EINVAL;
> + }

... and now pread(-1, ...) fails with EINVAL instead of EBADF.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/