Re: [PATCH v2 3/5] spi: sunxi: Add Allwinner A31 SPI controllerdriver

From: Mark Brown
Date: Fri Jan 31 2014 - 11:04:01 EST


On Fri, Jan 31, 2014 at 09:11:47AM +0100, Maxime Ripard wrote:

> Wouldn't it be better if it was suspended by default, and just waken
> up whenever the framework needs it?

The aim should be to come out of probe in that state if runtime PM is
enabled but don't do it with these hacks, do it by idling the device
at the end of probe for example. Apart from anything else this code
just looks ugly.

Attachment: signature.asc
Description: Digital signature