Re: [PATCH 08/17] spi: pl022: Fully gate clocks at request inactivity

From: Mark Brown
Date: Tue Feb 04 2014 - 12:08:32 EST


On Tue, Feb 04, 2014 at 04:58:49PM +0100, Ulf Hansson wrote:
> Use clk_disable_unprepare and clk_prepare_enable from the runtime PM
> callbacks, to fully gate|ungate clocks. Potentially this will save more
> power, depending on the clock tree for the current SOC.

The same patch has already been applied (I noticed and fixed it while
doing unrelated code review).

> pinctrl_pm_select_default_state(dev);
> - clk_enable(pl022->clk);
> + clk_prepare_enable(pl022->clk);

Someone should really make this check errors though!

Attachment: signature.asc
Description: Digital signature