Re: [RFC PATCHv2] usb: move hub init and LED blink work to powerefficient workqueue

From: Zoran Markovic
Date: Fri Feb 07 2014 - 07:04:00 EST


I believe there may still be use cases where you want to wake up the
same CPU that scheduled the work.

Thanks for the Ack. Can you please queue this for 3.14?

Regards, Zoran

On 2 February 2014 08:10, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, 1 Feb 2014, Zoran Markovic wrote:
>
>> From: Shaibal Dutta <shaibal.dutta@xxxxxxxxxxxx>
>>
>> Allow the scheduler to select the best CPU to handle hub initalization
>> and LED blinking work. This extends idle residency times on idle CPUs
>> and conserves power.
>>
>> This functionality is enabled when CONFIG_WQ_POWER_EFFICIENT is selected.
>>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
>> Cc: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
>> Cc: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>> Cc: Julius Werner <jwerner@xxxxxxxxxxxx>
>> Cc: Krzysztof Mazur <krzysiek@xxxxxxxxxxxx>
>> Cc: Matthias Beyer <mail@xxxxxxxxxxxxxxxx>
>> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
>> Cc: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>> Cc: Thomas Pugliese <thomas.pugliese@xxxxxxxxx>
>> Signed-off-by: Shaibal Dutta <shaibal.dutta@xxxxxxxxxxxx>
>> [zoran.markovic@xxxxxxxxxx: Rebased to latest kernel. Added commit message.
>> Changed reference from system to power efficient workqueue for LEDs in
>> check_highspeed() and hub_port_connect_change().]
>> Signed-off-by: Zoran Markovic <zoran.markovic@xxxxxxxxxx>
>
> Acked-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
>
> Is there some reason why schedule_delayed_work() doesn't use the
> power-efficient work queue by default?
>
> Alan Stern
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/