Re: [PATCH 04/21] fs: Add prototype declaration to appropriateheader file include/linux/bio.h

From: Josh Triplett
Date: Sun Feb 09 2014 - 08:06:13 EST


On Sun, Feb 09, 2014 at 06:30:39PM +0530, Rashika Kheria wrote:
> Add prototype declaration to header file include/linux/bio.h because it
> is used by more than one file.
>
> This eliminates the following warning in bio-integrity.c:
> fs/bio-integrity.c:214:14: warning: no previous prototype for âbio_integrity_tag_sizeâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

> Some of the API functions like bio_integrity_tag_size appears to be
> entirely unused. Such occurences should be pruned because they haven't
> been used in any driver.
>
> include/linux/bio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 7065452..d6791bb 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -332,6 +332,7 @@ extern struct bio *bio_clone_fast(struct bio *, gfp_t, struct bio_set *);
> extern struct bio *bio_clone_bioset(struct bio *, gfp_t, struct bio_set *bs);
>
> extern struct bio_set *fs_bio_set;
> +unsigned int bio_integrity_tag_size(struct bio *bio);
>
> static inline struct bio *bio_alloc(gfp_t gfp_mask, unsigned int nr_iovecs)
> {
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/