Re: [PATCH] regmap: Check readable regs in _regmap_read
From: Lars-Peter Clausen
Date: Mon Feb 10 2014 - 05:53:45 EST
On 02/10/2014 11:46 AM, Michal Simek wrote:
Check if regs are readable.
Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
---
drivers/base/regmap/regmap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 6a19515..7569dfc 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -1725,6 +1725,9 @@ static int _regmap_read(struct regmap *map, unsigned int reg,
int ret;
void *context = _regmap_map_get_context(map);
+ if (!regmap_readable(map, reg))
+ return -EIO;
+
This will cause issues with devices where registers are writable, but not
readable, but we keep the register value in the cache.
WARN_ON(!map->reg_read);
if (!map->cache_bypass) {
--
1.8.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/