Re: [PATCH 07/22] fnic: Use pci_enable_msix_range()

From: Suma Ramars (sramars)
Date: Tue Feb 11 2014 - 00:11:16 EST


Hi Alexander

The changes look good to me. Thanks for taking care of this

-Suma

On 04/02/14 4:46 PM, "Alexander Gordeev" <agordeev@xxxxxxxxxx> wrote:

>As result of deprecation of MSI-X/MSI enablement functions
>pci_enable_msix() and pci_enable_msi_block() all drivers
>using these two interfaces need to be updated to use the
>new pci_enable_msi_range() and pci_enable_msix_range()
>interfaces.
>
>Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
>Cc: Hiral Patel <hiralpat@xxxxxxxxx>
>Cc: Suma Ramars <sramars@xxxxxxxxx>
>Cc: Brian Uchino <buchino@xxxxxxxxx>
>Cc: linux-scsi@xxxxxxxxxxxxxxx
>Cc: linux-pci@xxxxxxxxxxxxxxx
>---
> drivers/scsi/fnic/fnic_isr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi/fnic/fnic_isr.c
>index 7d9b54a..0031c3e 100644
>--- a/drivers/scsi/fnic/fnic_isr.c
>+++ b/drivers/scsi/fnic/fnic_isr.c
>@@ -257,8 +257,8 @@ int fnic_set_intr_mode(struct fnic *fnic)
> fnic->raw_wq_count >= m &&
> fnic->wq_copy_count >= o &&
> fnic->cq_count >= n + m + o) {
>- if (!pci_enable_msix(fnic->pdev, fnic->msix_entry,
>- n + m + o + 1)) {
>+ if (pci_enable_msix_range(fnic->pdev, fnic->msix_entry,
>+ n + m + o + 1, n + m + o + 1) > 0) {
> fnic->rq_count = n;
> fnic->raw_wq_count = m;
> fnic->wq_copy_count = o;
>--
>1.7.7.6
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/