Re: [PATCH 0/2] A couple of sched patches

[Ingo Molnar]

* Juri Lelli <juri.lelli@xxxxxxxxx> wrote:

> This two patches (on top of tip/master as of today) fix bugs
> in sched/core. First one is a repost of
> http://comments.gmane.org/gmane.linux.kernel/1638425, and exposed,
> at least to me, another bug (fixed by second patch).

With today's -tip there's a new warning on UP builds:

  /home/mingo/tip/kernel/sched/deadline.c:993: warning: 'pull_dl_task' declared 'static' but never defined

And in general the #ifdef happiness of deadline.c is rather sad:

 comet:~/tip> grep '#ifdef' kernel/sched/deadline.c 
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SCHED_HRTICK
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SCHED_HRTICK
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SCHED_HRTICK
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP
 #ifdef CONFIG_SMP

All that needs to be cleaned up.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/