Re: [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c

From: Tejun Heo
Date: Thu Feb 13 2014 - 15:42:30 EST


On Thu, Feb 13, 2014 at 10:59:18AM -0500, Paul Gortmaker wrote:
> To fix:
>
> arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
> arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
> arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
> cc1: all warnings being treated as errors
> make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
>
> According to Stephen, these types of failures are caused by
> commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
> being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Darn, another one. David, can you please ack this one? I'll push it
through cgroup/for-3.15 so that -next doesn't break.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/