Re: [PATCH] spi: core: Validate lenght of the transfers in message

From: Mark Brown
Date: Fri Feb 14 2014 - 13:26:29 EST


On Thu, Feb 13, 2014 at 04:46:46PM +0200, Ivan T. Ivanov wrote:

> + /* No partial transfers accepted */
> + if (!n_words || xfer->len & (w_size - 1))
> + return -EINVAL;

Please write this using % rather than the & - it's a lot clearer what
it's checking for, I had to think what the above meant. Hopefully the
compiler will make it equally fast either way.

Attachment: signature.asc
Description: Digital signature