Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

[Mark Brown]

On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote:
> Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added.

Ah, sorry - I didn't notice that there were several different binding
documents in the patch.

> @@ -0,0 +1,49 @@
> +TI LMU LM3631 regulator device tree bindings
> +
> +Required properties:
> +  - compatible: "ti,lm3631-regulator"
> +
> +Optional properties:
> +  - regulator-name
> +  - regulator-min-microvolt
> +  - regulator-max-microvolt
> +  - regulator-always-on
> +  - regulator-boot-on
> +
> +  For those properties, please refer to:
> +  Documentation/devicetree/bindings/regulator/regulator.txt

This doesn't correspond to the example which says that there is an
optional property "regulators" which can contain regualators lcd_boost,
lcd_vpos and lcd_vneg.  It's also better to not enumerate all the
standard properties but just refer to the generic document (as you do).
That avoids confusion if new properties are added to the generic
regulator bindings.

The actual binding is fine, it's just the way it's documented.

Attachment: signature.asc
Description: Digital signature