Re: [PATCHv2] irtty-sir.c: Do not set_termios() on irtty_close()

From: David Miller
Date: Mon Feb 17 2014 - 16:28:35 EST


From: Tommie Gannert <tommie@xxxxxxxxxx>
Date: Mon, 17 Feb 2014 20:46:04 +0000

> From: Tommie Gannert <tommie@xxxxxxxxxx>
>
> Issuing set_termios() from irtty_close() causes kernel Oops for
> unplugged usb-serial devices.
>
> Since no other tty_ldisc calls set_termios() on close and no tty driver
> seem to check if tty->device_data is NULL or not on entry to set_termios(),
> the only solution I can come up with is to remove the irtty_stop_receiver()
> call, which only updates termios.
>
> Signed-off-by: Tommie Gannert <tommie@xxxxxxxxxx>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/