Re: [PATCH] serial: 8250_pci: unbreak last serial ports on NetMos 9865 cards

[Dmitry Eremin-Solenikov]

Hello,

On Tue, Feb 11, 2014 at 2:18 PM, Dmitry Eremin-Solenikov
<dbaryshkov@xxxxxxxxx> wrote:
> Aparently 9865 uses standard BAR encoding scheme (unlike 99xx cards).
> Current pci_netmos_9900_setup() uses wrong BAR indices for the 9865 PCI
> device, function 2. Using standard BAR indices makes all 6 ports work
> for me. Thus disable the NetMos 9900 quirk for NetMos 9865 pci device.

Do you need any additional details for the patch?

[skipped lspci]

>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 4697a51..143a381 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -784,7 +784,8 @@ static int pci_netmos_9900_setup(struct serial_private *priv,
>  {
>         unsigned int bar;
>
> -       if ((priv->dev->subsystem_device & 0xff00) == 0x3000) {
> +       if ((priv->dev->device != PCI_DEVICE_ID_NETMOS_9865) &&
> +           (priv->dev->subsystem_device & 0xff00) == 0x3000) {
>                 /* netmos apparently orders BARs by datasheet layout, so serial
>                  * ports get BARs 0 and 3 (or 1 and 4 for memmapped)
>                  */
> --
> 1.8.5.2
>



-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/