Re: [PATCH 01/10] mfd: Add TI LMU driver

From: Milo Kim
Date: Tue Feb 18 2014 - 18:59:06 EST


Hi Lee,

On 02/18/2014 05:21 PM, Lee Jones wrote:
+ pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0);

There is a global DT property for this already.

I've not found it yet, but I agree it looks like general property.
So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio".

Just re-use "gpio-enable". No need for it to be vendor specific.


Got it. Thanks!

This GPIO is used for enabling the device. So, "enable-gpio" is more appropriate name, isn't it?

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/