Re: [tip:x86/asmlinkage] lto: Handle LTO common symbols in module loader

[H. Peter Anvin]

On 02/20/2014 03:11 PM, Rusty Russell wrote:
> tip-bot for Joe Mario <tipbot@xxxxxxxxx> writes:
>> Commit-ID:  80375980f1608f43b47abc2671456b23ec68c434
>> Gitweb:     http://git.kernel.org/tip/80375980f1608f43b47abc2671456b23ec68c434
>> Author:     Joe Mario <jmario@xxxxxxxxxx>
>> AuthorDate: Sat, 8 Feb 2014 09:01:09 +0100
>> Committer:  H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
>> CommitDate: Thu, 13 Feb 2014 20:24:50 -0800
>>
>> lto: Handle LTO common symbols in module loader
>>
>> Here is the workaround I made for having the kernel not reject modules
>> built with -flto.  The clean solution would be to get the compiler to not
>> emit the symbol.  Or if it has to emit the symbol, then emit it as
>> initialized data but put it into a comdat/linkonce section.
> 
> Gah, as I said, fix the damn comment!
> 
>>  		case SHN_COMMON:
>> +			/* Ignore common symbols */
>> +			if (!strncmp(name, "__gnu_lto", 9))
>> +				break;
>> +
>>  			/* We compiled with -fno-common.  These are not
> 
> /* Ignore common symbols */ is so bad, it's not even wrong.
> 

Joe, Andi, could one of you submit an incremental patch to clean up this
comment?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/