Re: [PATCH] avr32: remove cpu_data macro to fix compiles

From: Wolfram Sang
Date: Mon Feb 24 2014 - 03:18:05 EST


On Mon, Feb 24, 2014 at 08:28:20AM +0100, Hans-Christian Egtvedt wrote:
> Around Sat 22 Feb 2014 09:28:27 +0100 or thereabout, Wolfram Sang wrote:
> > Having cpu_data as a parameterless macro can easily cause build failures
> > because it can be a variable name like in linux/pm_domain.h [1]. So,
> > remove the macro and convert its only user. Because this architecture
> > cannot do SMP, remove the whole SMP block, too. Only compile tested due
> > to no hardware.
>
> Looks sane, AVR32 doesn't support SMP, so this change should be fine.

Great!

> > [1] https://lists.01.org/pipermail/kbuild-all/2014-February/003252.html
> >
>
> clockevents/3.15 branch, mens what you have queued up for 3.15?

Daniel has picked up changes from me for 3.15, yes. Because those
contain COMPILE_TEST this build failure was triggered.

> I can queue this in my linux-next, and send Linus an early pull request the
> moment 3.14 is released.

That would be the best solution IMO. Thanks!

All the best,

Wolfram

Attachment: signature.asc
Description: Digital signature