Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

[Linus Walleij]

On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa
<delicious.quinoa@xxxxxxxxx> wrote:

> I am wondering about the change in usage of
> irq_find_mapping/irq_create_mapping.  It seems like all the GPIO
> drivers that use irq domains do it the way I was doing it

It is a well known problems that the kernel contain many bad
examples. When in doubt ask for a good example to be provided.

In gpio-omap.c you will find that this is done in the probe()
path.

> (that's
> where I got the idea in the first place): irq_create_mapping is used
> in the to_irq() function.  I guess this is a general direction all the
> other drivers will be encouraged to go in also?

Yes. The reason is that it should be possible to reques an IRQ
from an irqchip no matter whether the gpio_to_irq() function
was called first, as the APIs are orthogonal.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/