Re: [RFC PATCH for-next 3/4] epoll: struct epoll support

[Nathaniel Yazdani]

On 2/24/14, Jonathan Corbet <corbet@xxxxxxx> wrote:
> So I was just looking things over quickly, and something jumped out at
> me.  In ep_control():
>
>> +	} else if (!(*io) && epi) {
>> +		/* delete this eventpoll entry */
>> +		if (is_file_epoll(target)) {
>> +			tep = target->private_data;
>> +			mutex_lock_nested(&tep->mtx, 1);
>> +		}
>> +		if (is_file_epoll(target))
>> +			mutex_lock_nested(&tep->mtx, 1);
>
> How could that possibly work?  I can't imagine tep->mtx is going to
> react well to being locked a second time...

Wow...I have no idea how I missed that, must've been moving stuff
around and accidentally duplicated that somehow. Thanks for setting
me straight, this is why I like to start with an RFC :)

Appreciate the input,
Nate
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/