Re: [PATCH] net: phy: add suspend_halted module param

[Sebastian Hesselbarth]

On 02/25/2014 12:05 AM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Date: Mon, 24 Feb 2014 10:20:10 -0800
>
> > Hi Sebastian,
> >
> > 2014-02-23 8:58 GMT-08:00 Sebastian Hesselbarth
> > <sebastian.hesselbarth@xxxxxxxxx>:
> > > commit 1211ce53077164e0d34641d0ca5fb4d4a7574498
> > >    ("net: phy: resume/suspend PHYs on attach/detach")
> > > introduced a feature to suspend PHYs when entering halted state.
> > >
> > > Unfortunately, not all bootloaders properly power-up PHYs on reset
> > > and fail to access ethernet because the PHY is still powered down.
> > >
> > > Therefore, we add a boolean module parameter suspend_halted with
> > > default value of true. Disabling that parameter prevents PHYs from
> > > being suspended when entering halted state.
> > >
> > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> > > Reported-by: Andrew Lunn <andrew@xxxxxxx>
> > > ---
> > > Andrew, can you please re-test if disabling the feature does work on
> > > your board? I tried a bunch of mine, but none failed to power-up the
> > > PHY in u-boot.
> >
> > Would be good to get Andrew's testing on this just to make sure it
> > solves his problem. Otherwise:
> >
> > Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> I disagree with using a module parameter for this.
>
> Figure out the devices that cannot do this properly, and add
> an internal flag that this driver sets.

Hmm, as it seems to be a bootloader issue, it will be quite
impossible to determine if a board is affected or not.

I am still trying to get any of my boards to mis-behave the same
way to figure out what is really causing it.

We do still have 2-3 weeks to find a proper fix, don't we?

> Module parameters are terrible.

Maybe. If you prefer, I can remove the module param and leave
the sysfs entry?

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/