Re: [PATCH] ASoC: cs42888: Add codec driver support

[Nicolin Chen]

On Mon, Feb 24, 2014 at 04:32:06PM +0000, Austin, Brian wrote:
> 
> On Feb 24, 2014, at 10:06 AM, Nicolin Chen <Guangyu.Chen@xxxxxxxxxxxxx> wrote:
> 
> > On Mon, Feb 24, 2014 at 03:52:24PM +0000, Austin, Brian wrote:
> >>>> +	if (!IS_ERR(cs42888->clk))
> >>>> +		clk_disable_unprepare(cs42888->clk);
> >>> 
> >>> Does the device work without MCLK?
> >> Yes, MCLK is required. If you canât get the clock you should error out.
> > 
> > Wait...Regarding this clock part, I just forgot the reason I put the code:
> > 
> > 385         cs42888->clk = devm_clk_get(&i2c->dev, "mclk");
> > 386         if (IS_ERR(cs42888->clk))
> > 387                 dev_warn(&i2c->dev, "failed to get the clock: %ld\n",
> > 388                                 PTR_ERR(cs42888->clk));
> > 
> > was because the MCLK might be provided from SoC (DAI master) so it could
> > be totally controlled by CPU DAI driver, ESAI for example has its own
> > dividers to derive the HCKT clock (MCLK for Tx) from ahb clock in SoC
> > clock tree, in which case we might not easily pass a valid clock phandle
> > via DT. (RFC to this thought.)
> OK, Itâs an external MCLK source, so why not just handle that in the machine driver? 
> Usually you would want the clock enabled/disabled in the machine driver so if you donât get it, you can bail out there. 
> At least that is how I do our MCLKâs. Since you are only using the freq of the clock to derive modes, just put the clock initialization outside and just pass in the freq like you do in set_sysclk

Letting codec handle the clock here is trying to en/disable it only when using
it -- pm_runtime_resume/suspend() so that we can save power during idle states,
while putting it into machine driver, quite common in lots of machine drivers
though, would need us to enable it in the probe(), otherwise machine driver
can't finish the clock enabling before codec driver's pm_runtime_resume() as
pm_runtime_get_sync(codec_dai->dev) is almost the head of soc_pcm_open().

At first place, I did let this codec driver be totally exempt from this clock
handling. And it's quite fair and neat to do that in the machine driver till
this second thought came to me....

Thank you,
Nicolin Chen


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/