Re: [PATCH 0/9 v7] crypto:s5p-sss: Add DT and Exynos support

From: Herbert Xu
Date: Tue Feb 25 2014 - 01:16:43 EST


On Mon, Feb 17, 2014 at 03:14:26PM +0530, Naveen Krishna Chatradhi wrote:
> SSS module on Exynos4210, Exynos5250 and Exynos5420 SoCs has added
> features to the one on S5PV210. However with minor changes the s5p-sss.c
> driver can be reused to support SSS modules on Exynos4 and 5 SoCs.
>
> This patch set
> 1. Adds device tree support to the s5p-sss.c driver and Documentation
> 2. Adds code to support SSS module on Exynos4 and 5 SoCs
> 3. Adds device tree node to Exynos5250 and Exynos5420
> 4. Adds variant struct to handle the differences in SSS modules
> 5. Adds clk_prepare/clk_unprepare clocks to the s5p-sss.c driver
>
> Note: Compatible "exynos4210-secss" should work for Exynos4412 and
> Exynos5260 (Exynos5260, for which ARCH code is under review)
> I couldn't test on Exynos4412 and Exynos4210 boards, Should be able to
> test with addition of DT node and clocks support.
>
> Naveen Krishna Ch (7): [crypto-2.6.git]
> crypto:s5p-sss: Use platform_get_irq() instead of _byname()
> crypto:s5p-sss: Kconfig: Let Exynos SoCs select SSS driver
> crypto:s5p-sss: Look for the next request in the queue
> crypto:s5p-sss: Add device tree support
> crypto:s5p-sss: Add support for SSS module on Exynos
> crypto:s5p-sss: validate iv before memcpy
> crypto:s5p-sss: Use clk_prepare/clk_unprepare

FWIW these patches are fine by me.

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/