Re: [PATCH] sched: put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED

[Srikar Dronamraju]

> The struct sched_avg of struct rq is only used in case group
> scheduling is enabled inside __update_tg_runnable_avg() to update
> per-cpu representation of a task group.  I.e. that there is no need to
> maintain the runnable avg of a rq in the !CONFIG_FAIR_GROUP_SCHED case.
> 
> This patch guards struct sched_avg of struct rq and
> update_rq_runnable_avg() with CONFIG_FAIR_GROUP_SCHED.
> 

While this patch looks good, I see fields in sched_avg viz decay_count,
last_runnable_update, load_avg_contrib  only relevant to sched_entity.
i.e they don't seem to be updated or used for rq->avg. Should we look at
splitting sched_avg so that rq->avg doesn't have unwanted fields?

--
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/