Re: [PATCH 2/3] x86/hash: swap parameters of crc32_u32()

From: Daniel Borkmann
Date: Tue Feb 25 2014 - 15:34:31 EST


On 02/25/2014 09:26 PM, H. Peter Anvin wrote:
On 02/21/2014 02:33 AM, Jan Beulich wrote:
... to match its two callers (i.e. the alternative would have been to
swap the arguments at the call sites).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Francesco Fusco <ffusco@xxxxxxxxxx>
Cc: Daniel Borkmann <dborkman@xxxxxxxxxx>
Cc: Thomas Graf <tgraf@xxxxxxxxxx>
Cc: David S. Miller <davem@xxxxxxxxxxxxx>
---
arch/x86/lib/hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Jan, do you want to do an updated version of this patch? Daniel, I
presume you are going to push this patch?

Good point. I'm fine if this is going to be picked up
by x86 maintainers. Feel free to add my ...

Acked-by: Daniel Borkmann <dborkman@xxxxxxxxxx>

... if you want to do an updated version that also
includes our recent findings/discussion, Jan.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/