Re: [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for clang

From: H. Peter Anvin
Date: Tue Feb 25 2014 - 20:34:12 EST


On 02/25/2014 05:08 PM, behanw@xxxxxxxxxxxxxxxxxx wrote:
>
> +# enforce no-sse for clang
> +ifneq ($(COMPILER),clang)
> + KBUILD_CFLAGS += $(call cc-option,-mno-sse)
> + KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)
> +endif
> +

I'm *very* confused. You're doing ifneq here but you're talking about
it as if you are *adding* them for Clang, also these options are already
added elsewhere (lines 57, 64, 86, 89) so why add them here?

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/