Re: [PATCH 4/6] gpio / ACPI: Embed events list directly into struct acpi_gpio_chip

From: Mika Westerberg
Date: Wed Feb 26 2014 - 04:02:56 EST


On Tue, Feb 25, 2014 at 03:26:12PM +0100, Rafael J. Wysocki wrote:
> On Monday, February 24, 2014 06:00:09 PM Mika Westerberg wrote:
> > It is not necessary to have events as a pointer to list in struct
> > acpi_gpio_chip. Instead we can embed the list_head directly to struct
> > acpi_gpio_chip itself. This makes event handling a bit simpler because now
> > we don't need to check whether the pointer is NULL or not.
>
> It looks like I should have reviewed the whole series before commenting [2/6].
>
> Well, my modified comment would be "Why don't you fold this one into [2/6]?", then.

I will in the next version, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/