Re: linux-next: build failure after merge of the libata tree

From: Tejun Heo
Date: Wed Feb 26 2014 - 08:49:29 EST


On Wed, Feb 26, 2014 at 01:55:21PM +1100, Stephen Rothwell wrote:
> Hi Tejun,
>
> After merging the libata tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> drivers/ata/ahci_st.c:159:8: error: implicit declaration of function 'ahci_platform_put_resources' [-Werror=implicit-function-declaration]
> ahci_platform_put_resources(&pdev->dev, hpriv);
> ^
>
> Caused by commit 0d8d213703ff ("ahci: st: Add support for ST's SATA
> IP"). That function is defined as "static" in another file ...
>
> I have used the version of the libata tree from next-20140225 for today.

Right, that patch was against the previous version which didn't use
devres. The put_resources calls are no longer necessary. Will revert
the patch for now.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/