Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

[David Howells]

Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:

> 'flags' are u16 and the whole range is needed -> %04x

Done.  Note that %02x does not preclude more digits, but I guess it's better
to have things line up.

> for the address simply %03x should do.

Done.

> And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or
> %*phD at least?

My problem with that is that it increases the length of the output by 50% and
there's a hard limit on how much output we may produce.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/