Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing

[Jeff Layton]

On Thu, 27 Feb 2014 10:13:14 +0100
"Lorenz Bucher" <Lorenz.Bucher@xxxxxx> wrote:

> 
> Â
> Â
> 
> Gesendet:ÂMittwoch, 26. Februar 2014 um 21:26 Uhr
> Von:Â"Jeff Layton" <jlayton@xxxxxxxxx>
> An:Â"Lorenz Bucher" <Lorenz.Bucher@xxxxxx>
> Cc:Âsfrench@xxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Betreff:ÂRe: [PATCH] cifs: connect: added option krb5mi which may allow package signing
> On Wed, 26 Feb 2014 14:46:47 +0100
> "Lorenz Bucher" <Lorenz.Bucher@xxxxxx> wrote:
> 
> > Solves an issue with dfs where servers using package signing are
> > mixed with servers which don't use package signing.
> >
> > Signed-off-by: Lorenz Bucher <lorenz.bucher@xxxxxx>
> > ---
> > fs/cifs/connect.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index 56c152d..9d06dd8 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> > if (!value || !*value) {
> > cERROR(1, "no security value specified");
> > continue;
> > + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> > + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> > + CIFSSEC_MAY_SIGN;
> > } else if (strnicmp(value, "krb5i", 5) == 0) {
> > vol->secFlg |= CIFSSEC_MAY_KRB5 |
> > CIFSSEC_MUST_SIGN;
> 
> This looks like it applies to a really old kernel. I think that problem
> was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
> to fix.
> 
> --
> Jeff Layton <jlayton@xxxxxxxxx>
> 
> Its the current kernel from LTS Ubuntu 12.04
> 3.2.0-59-generic #90-Ubuntu SMP Tue Jan 7 22:43:51 UTC 2014
> 

Yep, that kernel is pretty old.

You're probably best off asking the ubuntu kernel maintainers to take
that patch (or asking them to backport 0b7bc84000d). It should
be reasonably safe but they'll have to make that call.

-- 
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/