Re: [PATCH v2] ASOC: dapm: add params_select callback

[Mark Brown]

On Thu, Feb 27, 2014 at 04:18:20PM +0000, nikesh@xxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
> From: nikesh <Nikesh.Oswal@xxxxxxxxxxxxxxxx>

As I said in my reply to your earlier patch:

| You need to fix both your git and e-mail setups, you should be using
| "Nikesh Oswal" or similar as your real name and more importantly your

Please don't ignore review comments, it tends not to be helpful.

Please do also use subject lines matching the style for the subsystem.

> dai-link params for codec-codec links were fixed. The fixed link between
> codec and another chip which may be another codec, baseband, bluetooth
> codec etc may require run time configuaration changes. This change
> provides an optional callback to select one of the param from a list
> of params.

OK, so the question now is why is this being done using a callback and
why is that callback picking from a list of predefined configurations?
You've not motivated this decision at all and it's not obvious to me
that it's the best approach (for example, why not just let the machine
driver set the parameters at any time rather than have it wait for a
callback)?

The picking from a list is especially odd, what I said in my previous
review was:

| If you look at the existing interface you'll also see that it takes an
| array of parameters rather than just a single parameter.  The idea was
| to extend the interface to provide a control to userspace allowing
| selection of one of the configurations from a list for use with cases
| like modems which can switch between 8kHz and 16kHz modes.

but if the selection is done purely in kernel space and we're not
constructing an enum then it's less clear that this is helpful.

Attachment: signature.asc
Description: Digital signature