Re: [PATCH 0/4] mfd: sec: Add support for S2MPS14

From: Lee Jones
Date: Fri Feb 28 2014 - 06:12:13 EST


> > > Few days ago I sent patches adding support for S2MPS14 device to the
> > > sec-core/s2mps11 drivers. These patches were rather large as they covered
> > > multiple subsystems so I decided to split everything into smaller, separate
> > > patches.
> > >
> > > The original patchset (version 3) can be found here:
> > > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/27194/focus=1649217
> > >
> > > This patchset is a small subset of the patchset related to the MFD core
> > > driver. It adds support for the S2MPS14 device only to the MFD core driver.
> > > I already obtained acks from Lee Jones during previous reviews.
> > >
> > > The patchset is based on current Linus' tree *with* patch:
> > > mfd: sec-core: Fix possible NULL pointer dereference when i2c_new_dummy error
> > > (which is already in Lee Jones' MFD tree)
> >
> > Can all of these patches be applied as they are?
> >
> > Is anything going to break as a result?
>
> Yes, they can be applied as they are. That was the reason behind
> splitting everything. Nothing should break, as far as I reviewed this
> and tested.

Very well, all applied, thanks.

> > > Krzysztof Kozlowski (4):
> > > mfd: sec: Add maximum RTC register for regmap config
> > > mfd: sec: Select different RTC regmaps for devices
> > > mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes
> > > mfd: sec: Add support for S2MPS14
> > >
> > > drivers/mfd/sec-core.c | 57 ++++++++++++-
> > > drivers/mfd/sec-irq.c | 97 ++++++++++++++++++++--
> > > include/linux/mfd/samsung/core.h | 1 +
> > > include/linux/mfd/samsung/irq.h | 31 ++++++-
> > > include/linux/mfd/samsung/rtc.h | 57 +++++++++++--
> > > include/linux/mfd/samsung/s2mps14.h | 152 +++++++++++++++++++++++++++++++++++
> > > 6 files changed, 378 insertions(+), 17 deletions(-)
> > > create mode 100644 include/linux/mfd/samsung/s2mps14.h
> > >
> >
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/