Re: [PATCH v7 1/1] watchdog: Add tegra watchdog

[Wim Van Sebroeck]

Hi Andrew,

> Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and
> later).  This driver will configure one watchdog timer that will reset the
> system in the case of a watchdog timeout.
> 
> This driver binds to the nvidia,tegra30-timer device node and gets its
> register base from there.
> 
> Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Tested-by: Stephen Warren <swarren@xxxxxxxxxx>
> Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx>
> ---
> Changes from v6:
> 
> Removed kref stuff.  We can't think of why it's needed here.
> 
> Changes from v5:
> 
> Changed license to GPL v2 per Stephen Warren's guidance.
> 
> Changes from v4:
> 
> Skip the error check from the platform_get_resources() call, because
> devm_ioremap_resource() correctly handles the case when res is NULL.
> 
> Changes from v3:
> 
> Applied Cuenter Roeck <linux@xxxxxxxxxxxx>'s comments.  In particular,
> since tegra_wdt_start() and tegra_wdt_stop() always return success, skip
> error checking for these calls.  Also, removed some unnecessarily verbose
> logging around which watchdog and timer ID is being used.  Fixed typo
> regarding the ref and unref callback setup.  Removed miscdev stuff.
> 
> Cuenter was right in that the watchdog doesn't need to be stopped prior
> to changing the timeout.  It is sufficient to just reprogram the watchdog
> with the new timeout.
> 
> Tested on T124.
> 
> To do a simple test, "echo 0 > /dev/watchdog0".  The target will reset when
> two minutes (the default heartbeat interval) have expired since the last
> write to /dev/watchdog0.
> 
>  Documentation/watchdog/watchdog-parameters.txt |   5 +
>  drivers/watchdog/Kconfig                       |  11 +
>  drivers/watchdog/Makefile                      |   1 +
>  drivers/watchdog/tegra_wdt.c                   | 302 +++++++++++++++++++++++++
>  4 files changed, 319 insertions(+)
>  create mode 100644 drivers/watchdog/tegra_wdt.c
> 

Patch added to linux-watchdog-next.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/