Re: [PATCH 2/3] perf: Disallow user space stack dump for function trace event

[Steven Rostedt]

On Sun,  2 Mar 2014 16:56:39 +0100
Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> Disabling user space stack dump for function trace event.
> 
> Recent issues with user space callchains processing within
> page fault handler tracing showed as Peter said 'there's
> just too much fail surface'.
> 
> The user space stack dump is just another source of the this issue.
> 
> Related list discussions:
>   http://marc.info/?t=139302086500001&r=1&w=2
>   http://marc.info/?t=139301437300003&r=1&w=2

For Linux git change logs, it's more preferable to use the kernel.org
link (it may go to the same place, but at least kernel.org has more
control of where it goes in the future).

Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1402211521040.6395@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx

-- Steve

> 
> Suggested-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Vince Weaver <vincent.weaver@xxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> ---
>  kernel/trace/trace_event_perf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
> index d5e01c3..c894614 100644
> --- a/kernel/trace/trace_event_perf.c
> +++ b/kernel/trace/trace_event_perf.c
> @@ -42,6 +42,13 @@ static int perf_trace_event_perm(struct ftrace_event_call *tp_event,
>  		 */
>  		if (!p_event->attr.exclude_callchain_user)
>  			return -EINVAL;
> +
> +		/*
> +		 * Same reason to disable user stack dump as for user space
> +		 * callchains above.
> +		 */
> +		if (p_event->attr.sample_type & PERF_SAMPLE_STACK_USER)
> +			return -EINVAL;
>  	}
>  
>  	/* No tracing, just counting, so no obvious leak */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/