Re: [PATCH 7/9] drivers: staging: rtl8187se: fixed checkpatch.pl errors

[axel . rasmussen1]

On Saturday 01 March 2014 9:36:31 PM Joe Perches wrote:
> On Sat, 2014-03-01 at 22:22 -0700, Axel Rasmussen wrote:
> > The definition of the driver's ChannelPlan array produced a large number
> > of checkpatch.pl errors. This patch fixes all of them by adding spaces
> > and wrapping the resulting overly-long lines.
> 
> I think the current code is better.
> 
> > diff --git a/drivers/staging/rtl8187se/r8180_core.c
> > b/drivers/staging/rtl8187se/r8180_core.c
> []
> 
> > @@ -2242,17 +2242,44 @@ static void watch_dog_adaptive(unsigned long data)
> 
> [for instance]
> 
> >  static struct rtl8187se_channel_list channel_plan_list[] = {
> > 
> > -	{{1,2,3,4,5,6,7,8,9,10,11,36,40,44,48,52,56,60,64},19},		/* FCC */
> 
> []
> 
> > +	/* FCC */
> > +	{{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 36, 40,
> > +		44, 48, 52, 56, 60, 64}, 19},
> 
> If you really do this, it may be better to
> remove the len variable and test for != 0
> instead of channel_plan_list[].len
> 
> So instead of:
> 
> drivers/staging/rtl8187se/r8180_core.c:
> 			for (i = 0; i < channel_plan_list[channel_plan].len; i++) {
> Maybe:
> 			for (i = 0; channel_plan_list[channel_plan].channel[i]; i++) {

True, removing the length and using a 0 terminating element would simplify the channel plan list, allowing it to just be a list of arrays, rather than a list of structs. The one thing I'd be curious about is, judging by the driver's TODO file, it seems that its existing private ieee80211 implementation is going to be replaced with one that already exists elsewhere in the kernel, so the entire channel plan list may disappear at that point? If true, I'm not sure it's worth doing anything very complicated to the existing implementation.

Maybe someone can confirm that this channel plan list will go away once the driver is integrated with drivers/net/wireless/rtl818x? Otherwise, I can alter this patch to replace struct rtl8187se_channel_list with a simple array of channels.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/