Re: [PATCH] usb: gadget: atmel_usba: Fix crashed during stopping when DEBUG is enabled

From: Felipe Balbi
Date: Mon Mar 03 2014 - 11:35:21 EST


On Fri, Feb 28, 2014 at 03:34:01PM +0100, Gregory CLEMENT wrote:
> The debug trace in the atmel_usba_stop function made the assumption
> that the driver pointer passed in parameter was not NULL. Since the
> commit "usb: gadget: udc-core: fix a regression during gadget driver
> unbinding", it was no more always true. This lead to a kernel crash.
>
> This commit now use the driver pointer stored in udc which fixes this
> issue.
>
> Since the commit which have triggered this issue was backported to the
> 3.2 stable branch, then this one should also be backported to the same
> kernel.
>
> Cc: stable@xxxxxxxxxxxxxxx # v3.2+
> Fixes: 511f3c5326ea (usb: gadget: udc-core: fix a regression during gadget driver unbinding)

this line shouldn't be here and you're missing a SoB line, can't take
this patch, sorry.

--
balbi

Attachment: signature.asc
Description: Digital signature