Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()

[Michal Nazarewicz]

>> On 03/04/2014 10:34 AM, Chuansheng Liu wrote:
>> >@@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
>> >  			 * we may end up with more data then user space has
>> >  			 * space for.
>> >  			 */
>> >-			ret = ep->status;
>> >-			if (io_data->read && ret > 0 &&
>> >-			    unlikely(copy_to_user(io_data->buf, data,
>> >-						  min_t(size_t, ret,
>> >-						  io_data->len))))
>> >-				ret = -EFAULT;
>> >+				ret = ep->status;

On Tue, Mar 04 2014, Felipe Balbi wrote:
>>    Why the indentation jumped suddenly to the right?

> On Tue, Mar 04, 2014 at 08:01:15PM +0300, Sergei Shtylyov wrote:
> because it was wrong before ;-)

Yep.  It looks like Robert's [2e4c7553: add aio support] introduced an
if-else-if-else flow but did not indent the code and I didn't caught it
when reviewing that patch.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  MichaÅ âmina86â Nazarewicz    (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--

Attachment: signature.asc
Description: PGP signature