Re: [PATCH tip] perf/x86/uncore: Add __init for uncore_cpumask_init().

[Stephane Eranian]

On Wed, Mar 5, 2014 at 10:58 AM, Dongsheng Yang
<yangds.fnst@xxxxxxxxxxxxxx> wrote:
> Commit 411cf180f introduce function uncore_cpumask_init() and it is only
> called in __init intel_uncore_init(). But it is not marked with __init,
> then the following warning is there when building.
>
I did not get this warning when building my kernels. But I agree
with the patch.

Acked-by: Stephane Eranian <eranian@xxxxxxxxxx>

> WARNING: vmlinux.o(.text+0x2464a): Section mismatch in reference from the function uncore_cpumask_init() to the function .init.text:uncore_cpu_setup()
> The function uncore_cpumask_init() references
> the function __init uncore_cpu_setup().
> This is often because uncore_cpumask_init lacks a __init
> annotation or the annotation of uncore_cpu_setup is wrong.
>
> This patch add __init for uncore_cpumask_init() function.
>
> Signed-off-by: Dongsheng Yang <yangds.fnst@xxxxxxxxxxxxxx>
> cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> cc: Paul Mackerras <paulus@xxxxxxxxx>
> cc: Ingo Molnar <mingo@xxxxxxxxxx>
> cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>
> cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> cc: Stephane Eranian <eranian@xxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> index b262c61..5c2537a 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -4229,7 +4229,7 @@ static int __init uncore_pmus_register(void)
>         return 0;
>  }
>
> -static void uncore_cpumask_init(void)
> +static void __init uncore_cpumask_init(void)
>  {
>         int cpu;
>
> --
> 1.8.2.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/