Re: [PATCH 31/48] uv: Replace __get_cpu_var

From: Christoph Lameter
Date: Wed Mar 05 2014 - 16:57:40 EST


The driver seems to use local64_t to define a single static instance of a
counter and then seems to think that it is safe to increment the counter
from multiple processors using local64_inc and friends. Common
misunderstanding and a reason why I wanted the this_cpu operations.

The counters seem to be exported via module parameters.. So I guess we
need to define these per cpu and then sum them up when they need to be
displayed.

Dimitri?

Maybe lets move this outside of this patchset.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/