Re: [PATCH] net: use raw_cpu ops in snmp stats bh

From: David Miller
Date: Thu Mar 06 2014 - 15:03:49 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Thu, 06 Mar 2014 07:04:32 -0800

> On Thu, 2014-03-06 at 06:44 -0800, Eric Dumazet wrote:
>
>> I think you missed a lot of mails sent by Chrisoph Lameter recently...
>
> s/Chrisoph/Christoph/
>
> Appropriate fix would be the following one, please submit this formally.
>
>
> Fixes: f19c29e3e391 ("tcp: snmp stats for Fast Open, SYN rtx, and data pkts")
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 5286228679bd..df063a32a177 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -87,7 +87,7 @@ static void tcp_event_new_data_sent(struct sock *sk, const struct sk_buff *skb)
> tcp_rearm_rto(sk);
> }
>
> - NET_ADD_STATS_BH(sock_net(sk), LINUX_MIB_TCPORIGDATASENT,
> + NET_ADD_STATS(sock_net(sk), LINUX_MIB_TCPORIGDATASENT,
> tcp_skb_pcount(skb));
> }

I'll take care of this, as follows:

====================