Re: [PATCH 1/3] staging: dgap: remove unneeded status variables

From: Greg Kroah-Hartman
Date: Thu Mar 06 2014 - 17:16:28 EST


On Mon, Mar 03, 2014 at 01:08:06AM +0400, Alexey Khoroshilov wrote:
> dgap_driver_start and dgap_Major_Control_Registered are used
> to keep status of initialization of the driver as a whole and its "Major Control".
> But the code that checks them is executed once on module init/unload.
> That makes no sense in these variables as far as their values are predictable
> at any time.
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> ---
> drivers/staging/dgap/dgap.c | 97 ++++++++++++++++++++-------------------------
> 1 file changed, 42 insertions(+), 55 deletions(-)

Due to other recent changes in this driver, none of these patches apply
anymore :(

Can you please redo them against my latest tree so that I can apply
them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/