Re: [PATCH 8/8] tools, perf: Make get_srcline fall back to sym+offset

[Jiri Olsa]

On Thu, Feb 27, 2014 at 08:22:32PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> When the source line is not found fall back to sym + offset.
> This is generally much more useful than a raw address.
> For this we need to pass in the symbol from the caller.
> For some callers it's awkward to compute, so we stay
> at the old behaviour.

could we fallback for 0 src lines as well? I'm getting following:

            |          |--99.85%-- _IO_file_xsputn@@GLIBC_2.2.5 .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0

also it would be handy to show raw address (object based).. maybe for -v option?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/