Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn

From: Jason Cooper
Date: Fri Mar 07 2014 - 08:46:39 EST


On Fri, Mar 07, 2014 at 11:56:11AM +0800, Linus Walleij wrote:
> On Fri, Mar 7, 2014 at 11:50 AM, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:
> > On Fri, Mar 07, 2014 at 11:48:25AM +0800, Linus Walleij wrote:
> >> On Fri, Mar 7, 2014 at 4:18 AM, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:
> >> > On Wed, Mar 05, 2014 at 01:03:10AM +0100, Sebastian Hesselbarth wrote:
> >> >> Pinctrl will WARN on missing DT resources, which is a little bit too
> >> >> noisy. Use dev_warn with FW_BUG instead.
> >> >>
> >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> >> >> ---
> >> >> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> >> >> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> >> >> Cc: Andrew Lunn <andrew@xxxxxxx>
> >> >> Cc: Gregory Clement <gregory.clement@xxxxxxxxxxxxxxxxxx>
> >> >> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >> >> Cc: devicetree@xxxxxxxxxxxxxxx
> >> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> >> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> >> ---
> >> >> drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++-
> >> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >> >
> >> > Applied to mvebu/pinctrl
> >>
> >> So are you carrying this patch, or shall I apply it to my tree?
> >>
> >> In the former case: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >
> > I'll send you a pull tomorrow.
>
> For a single patch?

Well, just the doc change and WARN change. I've already taken the dts
change into mvebu/dt (for arm-soc).

There should be no need for these two to be in mvebu's for-next, so if
it's easier for you to pick them, please do so.

I'll drop them from mvebu/pinctrl and update mvebu's for-next right now.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/